Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Switch] Update to follow current MD guidelines #24954

Merged
merged 5 commits into from Feb 17, 2021

Conversation

hxqlin
Copy link
Contributor

@hxqlin hxqlin commented Feb 16, 2021

This PR fixes #24944.

Changes in light mode:
light-mode

Changes in dark mode:
dark-mode

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 16, 2021

Details of bundle changes

Generated by 🚫 dangerJS against a7ea982

@oliviertassinari oliviertassinari added component: switch This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process labels Feb 16, 2021
@mbrookes mbrookes changed the title [Switch] Make Switch follow MD guidelines [Switch] Update Switch to follow current MD guidelines Feb 16, 2021
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR#24954
mui#24954
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR#24954
mui#24954
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR#24954
mui#24954
@mbrookes mbrookes changed the title [Switch] Update Switch to follow current MD guidelines [Switch] Update to follow current MD guidelines Feb 16, 2021
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR#24954
mui#24954
tchock added a commit to Bojagi/material-ui that referenced this pull request Feb 16, 2021
This is a copy of upstream PR#24954
mui#24954
@oliviertassinari oliviertassinari merged commit ff0d165 into mui:next Feb 17, 2021
@oliviertassinari
Copy link
Member

@hxqlin It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@hxqlin hxqlin deleted the fix-switch-md branch February 18, 2021 18:19
oliviertassinari added a commit to natac13/material-ui that referenced this pull request Feb 18, 2021
tchock added a commit to Bojagi/material-ui that referenced this pull request Mar 10, 2021
This is a copy of upstream PR#24954
mui#24954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: switch This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Switch] disabled={true} is not following the current MD guidelines
3 participants