New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextField] Fix FilledInput AA contrast issue #25046
[TextField] Fix FilledInput AA contrast issue #25046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should change the palette as a whole. If there's a problem with the TextField -> just change the TextField. If there's a problem with the palette -> show the problem with the palette. If that problem only exists with the TextField, don't change the palette since that can have unintended side-effects.
https://material.io/design/color/text-legibility.html#text-backgrounds |
@Dripcoding What do you think about splitting the change into two pull requests? The first one to update the palette, to get a proper entry in the changelog, and this one to polish the filled text field? |
@oliviertassinari I think splitting this PR makes sense so that each addresses a different issue. I'll split this PR once I get off work today. Also should I create a separate issue for the palette change? |
I don't think so, I think that detailing the motivation for the change is enough. |
@oliviertassinari @eps1lon I've split this PR with this for the FilledInput. #25060 is for changing the palette. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I get it. Thanks for taking the time explaining both issues!
@Dripcoding Perfect, a better aesthetic and a11y (I only hope the background is dark enough to be seen) |
Update opacity for light backgroundColor in FilledInput
Update opacity in palette
Fixes #249247