Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Pin playwright image to known working version #25080

Merged
merged 3 commits into from Feb 24, 2021
Merged

[core] Pin playwright image to known working version #25080

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
823a391
Set PLAYWRIGHT_BROWSERS_PATH globally
eps1lon Feb 24, 2021
34bcbcb
Upgrade to Ubuntu 20
eps1lon Feb 24, 2021
ef9abe7
Pin pw docker image to previously working version
eps1lon Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -21,6 +21,8 @@ defaults: &defaults
type: string
default: undefined
environment:
# Keep in sync with "Save playwright cache"
PLAYWRIGHT_BROWSERS_PATH: /tmp/pw-browsers
# expose it globally otherwise we have to thread it from each job to the install command
REACT_DIST_TAG: << parameters.react-dist-tag >>
TEST_GATE: << parameters.test-gate >>
Expand Down Expand Up @@ -88,7 +90,6 @@ commands:
name: Install js dependencies
command: yarn install --verbose
environment:
PLAYWRIGHT_BROWSERS_PATH: /tmp/pw-browsers
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: <<# parameters.browsers >>0<</ parameters.browsers >><<^ parameters.browsers >>1<</ parameters.browsers >>
- save_cache:
name: Save yarn cache
Expand All @@ -104,7 +105,7 @@ commands:
name: Save playwright cache
key: v5-playwright-{{ arch }}-{{ checksum "/tmp/playwright_info.json" }}
paths:
# Keep path in sync with "Install js dependencies"
# Keep path in sync with "PLAYWRIGHT_BROWSERS_PATH"
# Can't use environment variables for `save_cache` paths (tested in https://app.circleci.com/pipelines/github/mui-org/material-ui/37813/workflows/5b1e207f-ac8b-44e7-9ba4-d0f9a01f5c55/jobs/223370)
- /tmp/pw-browsers

Expand Down Expand Up @@ -323,7 +324,7 @@ jobs:
test_browser:
<<: *defaults
docker:
- image: mcr.microsoft.com/playwright:bionic
- image: mcr.microsoft.com/playwright@sha256:1700531ce01a3d974cc440bb8efcf43d31d58ee5f1d354fc21563ea5fe4291e6
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
steps:
Expand All @@ -346,7 +347,7 @@ jobs:
test_profile:
<<: *defaults
docker:
- image: mcr.microsoft.com/playwright:bionic
- image: mcr.microsoft.com/playwright@sha256:1700531ce01a3d974cc440bb8efcf43d31d58ee5f1d354fc21563ea5fe4291e6
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
steps:
Expand All @@ -373,7 +374,7 @@ jobs:
test_regressions:
<<: *defaults
docker:
- image: mcr.microsoft.com/playwright:bionic
- image: mcr.microsoft.com/playwright@sha256:1700531ce01a3d974cc440bb8efcf43d31d58ee5f1d354fc21563ea5fe4291e6
environment:
NODE_ENV: development # Needed if playwright is in `devDependencies`
steps:
Expand Down