[test] Wait on e2e server to start before starting runner #25476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param url | ||
| */ | ||
| async function attemptGoto(page: playwright.Page, url: string): Promise<boolean> { | ||
| const maxAttempts = 10; |
There was a problem hiding this comment.
Why have a max attempt if we already have a timeout on the before task?
There was a problem hiding this comment.
To answer my own question, to get an accurate error message.
There was a problem hiding this comment.
Because the timeout does not necessarily translate to the number of attempts considering we await other async tasks before. The maxAttempts is just something to statically verify the loop doesn't run forever.
For example, launching the browser might take 15s. Then we don't ever reach maxAttempts nor shouldn't we.
oliviertassinari
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/mui-org/material-ui/39638/workflows/d07cf743-eb36-4a71-b6a3-74400199ac2c/jobs/234518
We start server and runner concurrently but we didn't actually wait on the server. The regression suite did not have problems with this. Probably because starting the headful browser was enough time for the server to start.