Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update the codesandbox issue templates #25501

Merged
merged 1 commit into from Mar 25, 2021
Merged

[core] Update the codesandbox issue templates #25501

merged 1 commit into from Mar 25, 2021

Conversation

oliviertassinari
Copy link
Member

Closes #25497

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Mar 25, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 25, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 93d90de

@github-actions github-actions bot mentioned this pull request Mar 25, 2021
Closed
@oliviertassinari oliviertassinari merged commit 4d78b49 into mui:next Mar 25, 2021
@oliviertassinari oliviertassinari deleted the core-issue-template branch March 25, 2021 18:40
oliviertassinari added a commit that referenced this pull request Mar 25, 2021
@oliviertassinari
[core] Update the codesandbox issue templates (#25501)
0c7d8ce
eps1lon
eps1lon reviewed Mar 25, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did these change? These should at all points in time point to the same codesandbox. What should be changed is the codesandbox instead. Otherwise all the old links are outdated.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Mar 25, 2021 •
edited

@eps1lon The issue is that the "next" codesandbox is no longer accessible, it seems to have been lost. I have also assumed that since we redirect the URL, the old links will automatically point to the new ones of this PR. I used the opportunity to convert them to frozen templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defaul issue template is not working
3 participants
@oliviertassinari @mui-pr-bot @eps1lon