Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate Portal demos to emotion #25505

Merged

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Mar 25, 2021

Related to #16947

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 25, 2021

No bundle size changes

Generated by 🚫 dangerJS against d886032

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: Portal The React component. labels Mar 25, 2021
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving a note for @mnajdova. This made me wonder if we should document

import Portal from '@material-ui/unstyled/Portal';

instead of

import Portal from '@material-ui/core/Portal';

or if we should add an ## Unstyled hero section in the page.

@mnajdova
Copy link
Member

mnajdova commented Apr 1, 2021

I'm leaving a note for @mnajdova. This made me wonder if we should document

import Portal from '@material-ui/unstyled/Portal';

instead of

import Portal from '@material-ui/core/Portal';

or if we should add an ## Unstyled hero section in the page.

For the sake of simplicity from developer's perspective, I think we should leave the import

import Portal from '@material-ui/core/Portal';

Developers shouldn't care about the specifics of whether this component has styles or not. If they want to use the unstyled version, they may change the import to the unstyled package. We anyway aim to have an unstyled version for all components. +1 for adding some kind of Unstyled tag or something similar in the docs that indicates that this is an unstyled component.

@oliviertassinari
Copy link
Member

In this case, I would propose we add an ## Unstyled section on these pages with a mention to

import Portal from '@material-ui/unstyled/Portal';

While the unstyled nature of the demos on the page suggests, it's not obvious that it's available in this package too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Portal The React component. docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants