Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Call focus on escape #25509

Merged
merged 4 commits into from Mar 27, 2021
Merged

[SpeedDial] Call focus on escape #25509

merged 4 commits into from Mar 27, 2021

Conversation

tanmoyopenroot
Copy link
Contributor

fixes #25326

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 26, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 9aa94ae

@github-actions github-actions bot mentioned this pull request Mar 26, 2021
Closed
@oliviertassinari oliviertassinari added component: speed dial This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Mar 26, 2021
oliviertassinari
oliviertassinari approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. It seems that I broke it +1 year ago, when I refactored the SpeedDial to support the uncontrolled mode.

@eps1lon eps1lon merged commit 30b31b8 into mui:next Mar 27, 2021
@eps1lon
Copy link
Member

eps1lon commented Mar 27, 2021

@tanmoyopenroot Much appreciated, thanks!

@tanmoyopenroot tanmoyopenroot deleted the tanmoyopenroot/bug/fix-speeddial-focus-onclose branch March 27, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SpeedDial] Cannot open with Enter/Space after closed via Escape
4 participants
@tanmoyopenroot @mui-pr-bot @eps1lon @oliviertassinari