New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[List] Remove background inheritance of ListSubheader #25532
[List] Remove background inheritance of ListSubheader #25532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reduced the scope of the changes. Here, the objective is now to remove the background inheritance color approach to the dedicated background color. This is what we do with the Autocomplete component. It simplifies one of our demos and fixes an issue with the Select. IMHO, these are signals that the new approach performs better.
Regarding the onclick event of #18200. The proposed fix looked completely wrong, leaking outside of the scope (this is a select issue, not a list subheader issue). I have reverted it. |
Ok, How about this way? |
@tanmoyopenroot This path seems to have potential. I would like to raise that #18200 is related to #14943. It's in the same order of how to handle composability well. There is something else that caught my attention. The keyboard logic is already able to differentiate valid option from wrong ones. We should be able to leverage it. This rely on |
Will try to fix this |
Related to #18200