Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix Async demo in docs #25536

Merged
merged 1 commit into from Mar 28, 2021
Merged

[Autocomplete] Fix Async demo in docs #25536

merged 1 commit into from Mar 28, 2021

Conversation

kanish671
Copy link
Contributor

@kanish671 kanish671 commented Mar 28, 2021 •
edited by oliviertassinari

Fix #25495

@mui-pr-bot
Copy link

mui-pr-bot commented Mar 28, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against b13840e

@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Mar 28, 2021
@oliviertassinari oliviertassinari changed the title [Autocomplete] Fixing async Autocomplete example in docs [Autocomplete] Fix Async demo in docs Mar 28, 2021
@oliviertassinari oliviertassinari merged commit 54967c5 into mui:next Mar 28, 2021
@oliviertassinari
Copy link
Member

@kanish671 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@kanish671
Copy link
Contributor Author

Thank you! looking forward to creating more 😄

@kanish671 kanish671 deleted the issues/25495-autocomplete-async branch March 28, 2021 15:23
@au5ton
Copy link

au5ton commented Jun 11, 2021

Has this been published yet? I'm still seeing the old code at https://material-ui.com/components/autocomplete/#asynchronous-requests

@oliviertassinari
Copy link
Member

Yes, it has, see https://next.material-ui.com/components/autocomplete/#asynchronous-requests. If you are not on v5 yet, seriously consider upgrading now.

@oliviertassinari oliviertassinari mentioned this pull request Jun 29, 2021
Closed
1 task
@oliviertassinari oliviertassinari mentioned this pull request Aug 27, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] async examples of the new documentation broken
4 participants
@kanish671 @mui-pr-bot @oliviertassinari @au5ton