Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Set aria-expanded to false when listbox is collapsed #25545

Merged
merged 2 commits into from Mar 30, 2021
Merged

[Select] Set aria-expanded to false when listbox is collapsed #25545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b30ea79
[Select] Set aria-expanded to false when listbox is collapsed. (#25399)
hhkk28 Mar 29, 2021
aac996c
Update packages/material-ui/src/Select/Select.test.js
eps1lon Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/material-ui/src/Select/Select.test.js
View file
Open in desktop
Expand Up @@ -402,10 +402,10 @@ describe('<Select />', () => {
expect(getByRole('button', { hidden: true })).to.have.attribute('aria-expanded', 'true');
});

specify('aria-expanded is not present if the listbox isnt displayed', () => {
specify('aria-expanded="false" if the listbox isnt displayed', () => {
eps1lon marked this conversation as resolved.
Show resolved Hide resolved
const { getByRole } = render(<Select value="" />);

expect(getByRole('button')).not.to.have.attribute('aria-expanded');
expect(getByRole('button')).to.have.attribute('aria-expanded', 'false');
});

it('sets aria-disabled="true" when component is disabled', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/material-ui/src/Select/SelectInput.js
View file
Open in desktop
Expand Up @@ -369,7 +369,7 @@ const SelectInput = React.forwardRef(function SelectInput(props, ref) {
tabIndex={tabIndex}
role="button"
aria-disabled={disabled ? 'true' : undefined}
aria-expanded={open ? 'true' : undefined}
aria-expanded={open ? 'true' : 'false'}
aria-haspopup="listbox"
aria-label={ariaLabel}
aria-labelledby={[labelId, buttonId].filter(Boolean).join(' ') || undefined}
Expand Down