[Slider] Allow disabling the left and right thumbs swap #25547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/unstyled: parsed: +0.69% , gzip: +1.06% |
oliviertassinari
added
component: avatar
eps1lon
reviewed
Mar 29, 2021
oliviertassinari
requested changes
Mar 29, 2021
There was a problem hiding this comment.
- Agree, please create a new section in the documentation. Don't recycle the existing demos.
- In the "Minimum distance shift" demo, the constraint isn't respected when reaching the edges.
- When
disableSwapis true, I believe the other thumbs shouldn't show the value on hover.
|
@oliviertassinari I fixed all issues.
I disabled showing the value, but I wonder if I should also disable the hover effect. |
oliviertassinari
force-pushed
the
slider-disable-swap
branch
from
c964997
to
8c3445e
Compare
There was a problem hiding this comment.
I have tried to completely fix the UX on the new demo. At this point, I think that we only miss test cases to merge. The problem I went after:
- keyboard page up => value not bound
- keyboard right => swap of the index
- fast mouse move => stuck with a distance between the two thumbs above the min value
oliviertassinari
approved these changes
Mar 31, 2021
|
@michal-perlakowski Thanks for taking on this effort and clear the path toward a solution :) |
This was referenced Jan 24, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24831.
I'm not sure if the API and demo descriptions are good, so any suggestions are welcome.
Preview: https://deploy-preview-25547--material-ui.netlify.app/components/slider/#range-slider