Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Bump stylis-plugin-rtl requirement #25661

Merged
merged 1 commit into from Apr 12, 2021

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Apr 8, 2021

Done to ensure the fix implemented in styled-components/stylis-plugin-rtl#21 is pulled in.

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 8, 2021

No bundle size changes

Generated by 🚫 dangerJS against cd81c69

@eps1lon
Copy link
Member

eps1lon commented Apr 8, 2021

Fixes #24899

I couldn't spot any rtl related issues in https://next.material-ui.com/components/grid/#main-content. Is the issue outdated?

@mnajdova
Copy link
Member Author

mnajdova commented Apr 8, 2021

Fixes #24899

I couldn't spot any rtl related issues in https://next.material-ui.com/components/grid/#main-content. Is the issue outdated?

#24899 (comment) posted the same question, I remember that it was an issue, but seems like it is working in the latest release 🤷

@mnajdova
Copy link
Member Author

mnajdova commented Apr 9, 2021

Seems like the version with the fix was already installed -
image

I still think we should update our package.json what do you think @eps1lon ?

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Apr 9, 2021
@eps1lon eps1lon changed the title [docs] Bump stylis-plugin-rtl [docs] Bump stylis-plugin-rtl requirement Apr 12, 2021
@eps1lon
Copy link
Member

eps1lon commented Apr 12, 2021

Seems like the version with the fix was already installed -
image

I still think we should update our package.json what do you think @eps1lon ?

Sure, why not.

@eps1lon eps1lon merged commit 16a7dee into mui:next Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants