Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDial] Fix broken aria reference issue #25665

Merged
merged 6 commits into from Apr 10, 2021
Merged

[SpeedDial] Fix broken aria reference issue #25665

merged 6 commits into from Apr 10, 2021

Conversation

RiyaNegi
Copy link
Contributor

@RiyaNegi RiyaNegi commented Apr 8, 2021 •
edited by mnajdova

Fixes #19205

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 8, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against a28726c

@RiyaNegi RiyaNegi changed the title fix aria reference issue [SpeedDialAction] Fix broken aria reference issue Apr 8, 2021
@github-actions github-actions bot mentioned this pull request Apr 8, 2021
Closed
@mnajdova
Copy link
Member

mnajdova commented Apr 8, 2021

Let's also update the PlaygroundSpeedDial.tsx as per #19205 (comment)

eps1lon
eps1lon previously requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. This must be tested though.

@oliviertassinari oliviertassinari changed the title [SpeedDialAction] Fix broken aria reference issue [SpeedDial] Fix broken aria reference issue Apr 8, 2021
@eps1lon eps1lon added component: speed dial This is the name of the generic UI component, not the React module! PR: needs test The pull request can't be merged labels Apr 8, 2021
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 9, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 9, 2021
@RiyaNegi
Copy link
Contributor Author

RiyaNegi commented Apr 9, 2021

@oliviertassinari added test. Let me know if it requires any changes.

@oliviertassinari oliviertassinari removed the PR: needs test The pull request can't be merged label Apr 9, 2021
eps1lon
eps1lon approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eps1lon eps1lon merged commit e75402d into mui:next Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
accessibility a11y component: speed dial This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SpeedDial] Broken ARIA reference
5 participants
@RiyaNegi @mui-pr-bot @mnajdova @eps1lon @oliviertassinari