Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[typescript] Add muiName to declarations #25689

Merged
merged 1 commit into from Apr 12, 2021
Merged

[typescript] Add muiName to declarations #25689

merged 1 commit into from Apr 12, 2021

Conversation

michal-perlakowski
Copy link
Contributor

Fixes #25662.

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 9, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against cad0afa

@oliviertassinari oliviertassinari changed the title Add muiName to TypeScript declarations [typescript] Add muiName to declarations Apr 9, 2021
@github-actions github-actions bot mentioned this pull request Apr 9, 2021
Closed
eps1lon
eps1lon reviewed Apr 10, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other components already have the static property from where?

@michal-perlakowski
Copy link
Contributor Author

Other components don't have the muiName property.

@eps1lon eps1lon merged commit dff5532 into mui:next Apr 12, 2021
@michal-perlakowski michal-perlakowski deleted the typescript-muiName branch April 12, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

muiName is not part of Typescript typings for components
4 participants
@michal-perlakowski @mui-pr-bot @oliviertassinari @eps1lon