-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Styled Engine page #25911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The topics I can think of when it comes to the documentation of the @material-ui/styled-engine
package:
- How to switch from emotion to styled-components
- The
GlobalStyles
API. - The
styled
API - The
ThemeProvider
API - The
StyledEngineProvider
API - How to write a custom engine (can be kept short as I'm not sure anyone will really dive into it)
- How to migrate from
@material-ui/styles
? - How to configure SSR?
It depends on how far we want to go. This is a bit tricky as we have created our own API around emotion and styled-component to bridge the differences.
Regarding the "Styling engine" title. We could consider "Styled engine" to make a reference to the API.
I think that it would make sense to have a dedicated section, like @material-ui/styled used to have in the side nav.
cc @mbrookes for more feedback
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
Co-authored-by: Matt <github@nospam.33m.co>
In my opinion The second topic I think it's important is Regarding the API and how to write a custom engine, I would add it as a follow up PR under |
@mnajdova I have tried to push it forward with new commits, please review. Looks good to me Regarding the location of this page, is |
I was’t sure what is the best position to be honest. I thought it should answer the question how to customize the styled engine 😅 maybe under guides would be better overall.. |
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
changes look good 👍 |
Regarding the location, maybe we can have a section Styled Engine with few pages, like how to setup styled-components, API, setup custom styled engine etc.. what do you think? |
@mnajdova Yeah, it's another idea. I wonder if we have enough content to make it worthwhile. I don't know either what's the best structure. |
I will move it to guides tomorrow then, seems like the best option at the moment... Edit: Done :) |
@@ -295,6 +295,7 @@ | |||
"/guides": "How To Guides", | |||
"/guides/typescript": "TypeScript", | |||
"/guides/interoperability": "Style Library Interoperability", | |||
"/guides/styled-engine": "Styled Engine", | |||
"/guides/minimizing-bundle-size": "Minimizing Bundle Size", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Off-topic. @mbrookes Should we change the capitalization of the links to:
"/guides/minimizing-bundle-size": "Minimizing Bundle Size", | |
"/guides/minimizing-bundle-size": "Minimizing bundle size", |
?
Preview https://deploy-preview-25911--material-ui.netlify.app/guides/styled-engine/