Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add section for useFormControl #25927

Merged
merged 10 commits into from
Apr 30, 2021
Merged

[docs] Add section for useFormControl #25927

merged 10 commits into from
Apr 30, 2021

Conversation

t49tran
Copy link
Contributor

@t49tran t49tran commented Apr 24, 2021 •
edited by oliviertassinari

Add a doc section for the hook useFormControl to TextField doc page. Fix #19861.

Preview: https://deploy-preview-25927--material-ui.netlify.app/components/text-fields/#useformcontrol

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 24, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against d445ba8

@github-actions github-actions bot mentioned this pull request Apr 24, 2021
Closed
eps1lon
eps1lon requested changes Apr 24, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. We want to make sure we don't leak too many implementation details.

docs/src/pages/components/text-fields/UseFormControl.tsx Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
docs/src/pages/components/text-fields/text-fields.md Outdated Show resolved Hide resolved
@eps1lon eps1lon added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Apr 24, 2021
@oliviertassinari oliviertassinari changed the title [doc]: add a section for useFormControl to TextField doc [docs] Add section for useFormControl Apr 24, 2021
@oliviertassinari oliviertassinari added component: text field This is the name of the generic UI component, not the React module! and removed package: material-ui Specific to @mui/material labels Apr 24, 2021
@t49tran
Copy link
Contributor Author

t49tran commented Apr 25, 2021

Thanks for the review @eps1lon , I will update the PR accordingly.

@t49tran
Copy link
Contributor Author

t49tran commented Apr 25, 2021

The PR is updated @eps1lon

eps1lon
eps1lon requested changes Apr 25, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The choice of casing for types seems odd to me.

docs/src/pages/guides/api/api.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari mentioned this pull request Apr 25, 2021
Closed
@t49tran
Copy link
Contributor Author

t49tran commented Apr 28, 2021

I have updated the types / type casing. Is there anything else should be done for this PR ?

mnajdova
mnajdova approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mnajdova mnajdova merged commit ed171a0 into mui:next Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] Display helperText on focus only
5 participants
@t49tran @mui-pr-bot @oliviertassinari @mnajdova @eps1lon