Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Remove labelWidth prop #26026

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Apr 28, 2021

Breaking change

  • [Select] The labelWidth prop was removed. The label prop now fulfills the same purpose, using CSS layout instead of JavaScript measurement to render the gap in the outlined. The TextField already handles it by default.

    -<Select variant="outlined" labelWidth={20} />
    +<Select variant="outlined" label="Gender" />

Part of #20012
Closes #22799

Preview: https://deploy-preview-26026--material-ui.netlify.app/components/text-fields/

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 28, 2021

Details of bundle changes

@material-ui/core: parsed: -0.10% 😍, gzip: -0.09% 😍

Generated by 🚫 dangerJS against 4d9d64f

@oliviertassinari oliviertassinari added breaking change component: select This is the name of the generic UI component, not the React module! labels Apr 28, 2021
@m4theushw m4theushw changed the title [TextField][Select] Remove labelWidth prop [Select] Remove labelWidth prop Apr 28, 2021
@oliviertassinari oliviertassinari merged commit 73b19d6 into mui:next Apr 30, 2021
@oliviertassinari
Copy link
Member

@m4theushw Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] Remove labelWidth prop
3 participants