[Box] Remove the clone prop
#26031
Merged
[Box] Remove the clone prop
#26031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
Co-authored-by: Marija Najdova <mnajdova@gmail.com>
| - <Button>Save</Button> | ||
| -</Box> | ||
| +<Button sx={{ border: '1px dashed grey' }}>Save</Button> | ||
| ``` | ||
|
|
||
| 2. Use render props |
There was a problem hiding this comment.
It looks like we can drop this as well. It was added to solve the same problem that sx handles now.
Maybe a follow up or in the same PR? I mean, the problem we go after is the same, so happy with both options.
There was a problem hiding this comment.
A follow up PR is better for the release notes.
oliviertassinari
approved these changes
Apr 29, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Box] Remove the
cloneprop because its behavior can be obtained using thesxprop.Part of #20012
Closes #18496