[Tabs] Fix keyboard traversal over disabled tabs #26061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +0.07% , gzip: +0.10% |
oliviertassinari
added
accessibility
oliviertassinari
approved these changes
Apr 29, 2021
oliviertassinari
changed the title
eps1lon
requested changes
Apr 29, 2021
|
Now that we have almost (the autocomplete supports nested focusable DOM structure, so it's different) 3 times the same logic in the codebase, we could consider abstracting it once we hit a 4th time. |
|
@anish-khanna Great job, it went smooth. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25923
Preview: https://deploy-preview-26061--material-ui.netlify.app/components/tabs/#disabled-tab