[IconButton] Fix default color prop

[Jack-Works]

• I have followed (at least) the PR section of the contributing guide.

[mui-pr-bot]

No bundle size changes

Generated by 🚫 dangerJS against 3944919

[eps1lon]

Thank! Could you also adjust the .propTypes in IconButton.js so that the documentation is updated as well?

[oliviertassinari]

It looks like a leftover from #21594. We still want to kill 'default' as a valid name: #13028. In SvgIcon/Icon components, this default color is called action. Would this name work?

[Jack-Works]

It looks like a leftover from #21594. We still want to kill 'default' as a valid name: #13028. In SvgIcon/Icon components, this default color is called action. Would this name work?

I see "default" still getting processed in the JS file. So you mean I should replace 'default' by 'action'?

[oliviertassinari]

@Jack-Works I think that there are two layers to this problem:

1. Fix the types/prop-types to match the implementation, this is what you started and Sebastian proposed to push further. This is already a win on its own, it could be merged as-is.
2. Fix the name of the default color. You have understood my proposal correctly. I think that it could be done here, or later.

I guess we can start slow, a fix first

[oliviertassinari]

@Jack-Works Thanks for raising

[Jack-Works]

Upgraded to alpha 33 but I see there is no "action" type

[oliviertassinari]

@Jack-Works Yes, the idea with this iteration was to fix the types, to have them sound. Regarding renaming default -> action, it's not something that we have done yet, this is for #13028.