Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal][pickers] Explicit default toolbar components #26075

Merged
merged 6 commits into from
May 1, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Apr 30, 2021

I don't see any value in declaring the default value once. We didn't even de-duplicate much since we still need to import the "right" thing and declare the default value.

@eps1lon eps1lon added the component: pickers This is the name of the generic UI component, not the React module! label Apr 30, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Apr 30, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 7ead457

@eps1lon eps1lon marked this pull request as ready for review April 30, 2021 20:33
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 1, 2021
@eps1lon
Copy link
Member Author

eps1lon commented May 1, 2021

Will fix documentation in a follow-up.

@eps1lon eps1lon merged commit 9725aad into mui:next May 1, 2021
@eps1lon eps1lon deleted the chore/pickers/defaulttoolbarcomponent branch May 1, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants