[core] Remove more dependencies on @material-ui/styles
#26100
Conversation
|
@material-ui/core: parsed: -0.29% 😍, gzip: -0.32% 😍 |
| +import { StylesProvider } from '@material-ui/styles'; | ||
| ``` | ||
|
|
||
| # useThemeVariants |
There was a problem hiding this comment.
Has this ever been public?
There was a problem hiding this comment.
I saw that it was exported. We can even remove it, with the new styles engine is not required anymore.
There was a problem hiding this comment.
Would leave it in the end when we cleanup the @material-ui/styled package, I'd just remove it from @material-ui/core/styles right now.
| @@ -112,7 +112,8 @@ We will see how this is passed along in the `renderFullPage` function. | |||
| import express from 'express'; | |||
There was a problem hiding this comment.
Looks like this page is outdated now
There was a problem hiding this comment.
Right, should we drop it? We should maybe just change to content to reflect the new styled engine
There was a problem hiding this comment.
We could do this, maybe in a follow-up?
There was a problem hiding this comment.
Leaving this comment open for visibility then
| @@ -2,7 +2,8 @@ import express from 'express'; | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
At some point, we can kill @ServerStyleSheets` from this example
zannager
added
package: styles
BREAKING CHANGES
createGenerateClassName
The
createGenerateClassNamemodule is no longer exported from@material-ui/core/styles. You should import it directly from@material-ui/styles.jssPreset
The
jssPresetvariable is no longer exported from@material-ui/core/styles. You should import it directly from@material-ui/styles.ServerStyleSheets
The
ServerStyleSheetsclass is no longer exported from@material-ui/core/styles. You should import it directly from@material-ui/styles.StylesProvider
The
StylesProvidercomponent is no longer exported from@material-ui/core/styles. You should import it directly from@material-ui/styles.useThemeVariants
The
useThemeVariantshook is no longer exported from@material-ui/core/styles. You should import it directly from@material-ui/styles.This PR removes the re-exported utliities from
@material-ui/stylesin@material-ui/core, as a requirement for removing the dependency to@material-ui/stylesin core.