Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve react@experimental compat #26116

Merged
merged 4 commits into from
May 5, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 4, 2021

Cherry-picked some enhancements from https://github.com/mui-org/material-ui/pull/26107/files that are useful when testing react@experimental.

@eps1lon eps1lon added the core Infrastructure work going on behind the scenes label May 4, 2021
[
'next/babel',
{
'preset-react': { runtime: 'automatic' },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next only uses automatic in react@^17.0.0-rc.1 but disregards the new JSX runtime in React 16 and 15 as well as the other release channels.

We're forcing it in our root config as well so you can look at this as a consistency change as well.

@mui-pr-bot
Copy link

mui-pr-bot commented May 4, 2021

No bundle size changes

Generated by 🚫 dangerJS against 4553524

@eps1lon eps1lon marked this pull request as ready for review May 4, 2021 07:08
@eps1lon eps1lon closed this May 5, 2021
@eps1lon eps1lon reopened this May 5, 2021
@eps1lon eps1lon merged commit 58c7e70 into mui:next May 5, 2021
@eps1lon eps1lon deleted the core/react-18-enhance branch May 5, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants