[pickers] Remove customization of internal components #26118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
breaking change
component: pickers
| MuiPickersToolbar: PickersToolbarClassKey; | ||
| MuiPickersToolbarButton: PickersToolbarButtonClassKey; | ||
| MuiPickersToolbarText: PickersToolbarTextClassKey; | ||
| MuiPickersYear: PickersYearClassKey; | ||
| MuiTabList: TabListClassKey; | ||
| MuiTabPanel: TabPanelClassKey; |
There was a problem hiding this comment.
A side note.
@mnajdova Since we have changed the theme structure, should we drop this file? (and props.d.ts)
There was a problem hiding this comment.
Aren't they are still used in the theme augmentation, how can we drop them? As far as I can see in https://github.com/eps1lon/material-ui/blob/next/packages/material-ui-lab/src/themeAugmentation/components.d.ts we still depend on them extending the overrides.d.ts
There was a problem hiding this comment.
Ah yes right. I wonder if having them under the same file could be clearer. It seems daunting to keep these 3 files in sync.
There was a problem hiding this comment.
Good point, let me see how it would look like if we change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this in a single PR instead of spreading it over the various emotion PRs.
BREAKING CHANGE
Removed customization of various internal picker components.
We're reworking customization over the next weeks. In its current form the customization story was sometimes missing, sometimes wrong and in all cases we don't know how this would be used. Since the pickers are subject to heavy refactoring it is likely that some of these components will be removed in the upcoming weeks.
Removed customization points:
MuiClockMuiClockNumberMuiClockPointerMuiDatePickerToolbarMuiPickersFadeTransitionMuiPickersModalDialogMuiPickersMonthMuiPickersPopperMuiPickersSlideTransitionMuiPickersToolbarMuiPickersToolbarButtonMuiPickersToolbarTextMuiPickersYearMuiPickerMuiPickersArrowSwitcherMuiPickersCalendarMuiPickersCalendarHeader