[internal][pickers] Pass desktop wrapper props explicitly #26120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
component: pickers
|
@material-ui/lab: parsed: +0.11% , gzip: +0.16% |
eps1lon
commented
May 4, 2021
| @@ -47,9 +47,14 @@ const DesktopDatePicker = React.forwardRef(function DesktopDatePicker<TDate>( | |||
| const validationError = useDateValidation(props) !== null; | |||
| const { pickerProps, inputProps, wrapperProps } = usePickerState(props, valueManager); | |||
|
|
|||
| // Note that we are passing down all the value without spread. | |||
| // It saves us >1kb gzip and make any prop available automatically on any level down. | |||
There was a problem hiding this comment.
make any prop available automatically on any level down
That's not a good thing if we don't see what props are available where because they'll eventually get used creating a coupling that might've not been intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears up where props goes.
Minor step with the goal of removing the
ResponsiveWrapper.