-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update templates, premium-themes to use makeStyles
from @material-ui/styles
#26131
Conversation
mnajdova
commented
May 4, 2021
- I have followed (at least) the PR section of the contributing guide.
@@ -1,5 +1,6 @@ | |||
import * as React from 'react'; | |||
import { makeStyles } from '@material-ui/core/styles'; | |||
import { makeStyles } from '@material-ui/styles'; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because of import { Theme } from '@material-ui/core/styles';
, maybe we should move the import to the bottom?
x the other cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me try that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint was complaining because of the order of the imports https://app.circleci.com/pipelines/github/mui-org/material-ui/41634/workflows/27c305d8-3e4b-4004-bcef-9d1dff281f42/jobs/248727 I reverted the changes.