Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Synchronize horizontal sticky header position with body #26159

Merged
merged 1 commit into from
May 7, 2021
Merged

[Table] Synchronize horizontal sticky header position with body #26159

merged 1 commit into from
May 7, 2021

Conversation

LiKang6688
Copy link
Contributor

@LiKang6688 LiKang6688 commented May 6, 2021 •
edited by oliviertassinari

@mui-pr-bot
Copy link

mui-pr-bot commented May 6, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against da4c95a

@LiKang6688 LiKang6688 changed the title [Fix]make the header look good when scrolling [Fix] Make the header look good when scrolling May 6, 2021
@github-actions github-actions bot mentioned this pull request May 6, 2021
Closed
@eps1lon eps1lon changed the title [Fix] Make the header look good when scrolling [docs] Make the header look good when scrolling May 6, 2021
@eps1lon eps1lon changed the title [docs] Make the header look good when scrolling [table] Make the sticky header look good when scrolling May 6, 2021
@eps1lon eps1lon added the component: table This is the name of the generic UI component, not the React module! label May 6, 2021
eps1lon
eps1lon reviewed May 6, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the sticky header look good when scrolling

Could you elaborate what you mean by "good"? The title is important for our changelog and "good" is an ambigious term.

@LiKang6688 LiKang6688 changed the title [table] Make the sticky header look good when scrolling [table] the content in the header does not move but is hidden by its right content when scrolling May 6, 2021
@LiKang6688 LiKang6688 changed the title [table] the content in the header does not move but is hidden by its right content when scrolling [table] the content in the fixed header does not move but is hidden by its right content when scrolling May 6, 2021
@LiKang6688
Copy link
Contributor Author

Make the sticky header look good when scrolling

Could you elaborate what you mean by "good"? The title is important for our changelog and "good" is an ambigious term.

sure. Made an update and welcome suggestions

@LiKang6688 LiKang6688 changed the title [table] the content in the fixed header does not move but is hidden by its right content when scrolling [table] The content in the fixed header does not move but is hidden by its right content when scrolling May 6, 2021
@oliviertassinari oliviertassinari changed the title [table] The content in the fixed header does not move but is hidden by its right content when scrolling [Table] Synchronize the horizontal sticky header positon May 6, 2021
@oliviertassinari oliviertassinari changed the title [Table] Synchronize the horizontal sticky header positon [Table] Synchronize horizontal sticky header position May 6, 2021
@oliviertassinari oliviertassinari changed the title [Table] Synchronize horizontal sticky header position [Table] Synchronize horizontal sticky header position with body May 6, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented May 6, 2021 •
edited

It makes sense, we have the same behavior on https://material-ui.com/components/data-grid/#commercial-version, the scroll position of the header and the body is synchronized horizontally. This style originates from the author that introduced the feature, it's the first time we rework it.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 6, 2021
@eps1lon eps1lon merged commit 737786e into mui:next May 7, 2021
@eps1lon
Copy link
Member

eps1lon commented May 7, 2021

@LiKang6688 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LiKang6688 @mui-pr-bot @oliviertassinari @eps1lon