-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fixed React.forwardRef missing display name ESLint error #26160
Conversation
@arpitBhalla you need to run
for solving the CI errors. Otherwise, the changes look good 👍 |
@mnajdova Still failing 😟 |
Generally, you should work on issues in a new branch not the default branch. That way we can easier determine what files changed. Since you just committed the changes to your Our contributing guide describes the pull request workflow in more detail. I went ahead and fixed the formatting and typing issues |
@eps1lon I am sorry |
No need to apologize. That's why we have all these automated checks so that we can work on these issues before they become a problem. |
@arpitBhalla It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
Thank you @eps1lon @oliviertassinari |
Fixes #25975