Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixed React.forwardRef missing display name ESLint error #26160

Merged
merged 5 commits into from May 7, 2021
Merged

[docs] Fixed React.forwardRef missing display name ESLint error #26160

merged 5 commits into from May 7, 2021

Conversation

arpitBhalla
Copy link
Contributor

Fixes #25975

@mui-pr-bot
Copy link

mui-pr-bot commented May 6, 2021

No bundle size changes

Generated by 🚫 dangerJS against 6a40031

@mnajdova
Copy link
Member

mnajdova commented May 6, 2021

@arpitBhalla you need to run

yarn prettier
yarn docs:typescript:formatted

for solving the CI errors. Otherwise, the changes look good 👍

@arpitBhalla
Copy link
Contributor Author

@mnajdova Still failing 😟

@eps1lon
Copy link
Member

eps1lon commented May 6, 2021

@mnajdova Still failing

Generally, you should work on issues in a new branch not the default branch. That way we can easier determine what files changed. Since you just committed the changes to your next branch, we can't determine the changed files which is why yarn prettier did not format every file.

Our contributing guide describes the pull request workflow in more detail.

I went ahead and fixed the formatting and typing issues

@arpitBhalla
Copy link
Contributor Author

@eps1lon I am sorry

@eps1lon
Copy link
Member

eps1lon commented May 6, 2021

@eps1lon I am sorry

No need to apologize. That's why we have all these automated checks so that we can work on these issues before they become a problem.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label May 6, 2021
@eps1lon eps1lon merged commit 4b4e1cd into mui:next May 7, 2021
@eps1lon
Copy link
Member

eps1lon commented May 7, 2021

@arpitBhalla It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@arpitBhalla
Copy link
Contributor Author

Thank you @eps1lon @oliviertassinari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Fix React.forwardRef missing display name ESLint error
5 participants