Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Fix support for null children in TabList #26170

Merged
merged 4 commits into from
May 7, 2021

Conversation

hubertokf
Copy link
Contributor

Closes #26166

@mui-pr-bot
Copy link

mui-pr-bot commented May 6, 2021

Details of bundle changes

Generated by 🚫 dangerJS against d8c18f7

@oliviertassinari oliviertassinari changed the title [TabList] Accept null children [Tabs] Fix support for null children in TabList May 6, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! labels May 6, 2021
@hubertokf
Copy link
Contributor Author

Thank you for adding to the pull request @oliviertassinari! I based it on what you did in the last PR.
If I understood, ReactNode can represent null, but ReactElement can't. Is that right?

@eps1lon eps1lon merged commit 1656b89 into mui:next May 7, 2021
@eps1lon
Copy link
Member

eps1lon commented May 7, 2021

@hubertokf It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@oliviertassinari
Copy link
Member

@hubertokf Correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TabList] Conditional rendering of Tab fails
4 participants