Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Rename values of the reason argument #26172

Merged
merged 1 commit into from
May 7, 2021
Merged

[Autocomplete] Rename values of the reason argument #26172

merged 1 commit into from
May 7, 2021

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented May 6, 2021 •
edited by oliviertassinari

Breaking changes

  • [Autocomplete] Rename the values of the reason argument in onChange and onClose for consistency:

    1. create-option to createOption
    2. select-option to selectOption
    3. remove-option to removeOption

Part of #20012

@mui-pr-bot
Copy link

mui-pr-bot commented May 6, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 698391b

@oliviertassinari oliviertassinari added breaking change component: autocomplete This is the name of the generic UI component, not the React module! labels May 6, 2021
@github-actions github-actions bot mentioned this pull request May 6, 2021
Closed
@m4theushw m4theushw mentioned this pull request May 7, 2021
Closed
@oliviertassinari oliviertassinari mentioned this pull request May 7, 2021
Closed
2 tasks
@m4theushw m4theushw merged commit ac3506a into mui:next May 7, 2021
@m4theushw m4theushw deleted the rename-autocomplete-reason branch May 7, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: autocomplete This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m4theushw @mui-pr-bot @oliviertassinari