Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix missing 'createOption' in AutocompleteCloseReason type #26197

Merged
merged 1 commit into from May 10, 2021
Merged

[Autocomplete] Fix missing 'createOption' in AutocompleteCloseReason type #26197

merged 1 commit into from May 10, 2021

Conversation

Gautam-Arora24
Copy link
Contributor

@Gautam-Arora24 Gautam-Arora24 commented May 8, 2021 •
edited

Added createOption to AutocompleteCloseReason type based on @oliviertassinari suggestion.

Fixes: #26176

@mui-pr-bot
Copy link

mui-pr-bot commented May 8, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 5aad007

@oliviertassinari oliviertassinari changed the title [AutoComplete] Add 'createOption' to AutocompleteCloseReason type. [Autocomplete] Fix missing 'createOption' in AutocompleteCloseReason type May 8, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! typescript labels May 8, 2021
@github-actions github-actions bot mentioned this pull request May 8, 2021
Closed
@Gautam-Arora24
Copy link
Contributor Author

Gautam-Arora24 commented May 8, 2021 •
edited

What's the reason that these tests are failing?
PS - Circle CI is showing me this - Failed prop type: The prop position is marked as required in ForwardRef(InputAdornment), but its value is undefined. But it doesn't make any sense considering the changes I have done.

@oliviertassinari oliviertassinari merged commit d7e85c3 into mui:next May 10, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented May 10, 2021 •
edited

@Gautam-Arora24 Thanks!

What's the reason that these tests are failing?

It's flaky, make sure your fork is based on the latest version of HEAD, it could help a bit for the next PR (in case we have done fix)

@Gautam-Arora24
Copy link
Contributor Author

Ya, I think that failures might be because my branch was behind the current upstream 'next'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Close reason type does not contain 'create-option'
3 participants
@Gautam-Arora24 @mui-pr-bot @oliviertassinari