[NProgressBar] Fix invalid ARIA and HTML #26234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested changes
May 10, 2021
There was a problem hiding this comment.
The bar is no longer going to the end, we will likely polish it #25889, but we might as well keep the UX identical until we do
Screen.Recording.2021-05-10.at.16.56.45.mov
HEAD:
Screen.Recording.2021-05-10.at.16.58.00.mov
oliviertassinari
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
roleinstead of using an invalid rolebarIf we want to use
progressbarwe would need to provide a name.divand pseudo selectors instead ofdtandddwhich is invalid markupI understand that there's ongoing work to promote this component to core (#25889), but in its current state it's blocking automated a11y trests. This fix should be propagated to
@material-ui/docsanyway.https://deploy-preview-26234--material-ui.netlify.app/getting-started/templates/