Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Fix hiddenLabel type of FilledInput #26290

Merged
merged 6 commits into from May 17, 2021
Merged

[TextField] Fix hiddenLabel type of FilledInput #26290

merged 6 commits into from May 17, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented May 14, 2021 •
edited

fix #26289

@mui-pr-bot
Copy link

mui-pr-bot commented May 14, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against c149fda

@siriwatknp siriwatknp changed the title [Typescript] add hiddenLabel proptype to FilledInput [Typescript] add hiddenLabel proptype to FilledInput May 14, 2021
@github-actions github-actions bot mentioned this pull request May 14, 2021
Closed
mnajdova
mnajdova requested changes May 14, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add *.spec.ts file to test types, no need for adding demo/regressions, they are more expensive.

@oliviertassinari oliviertassinari changed the title [Typescript] add hiddenLabel proptype to FilledInput [TextField] Fix hiddenLabel ptype to FilledInput May 14, 2021
@oliviertassinari oliviertassinari changed the title [TextField] Fix hiddenLabel ptype to FilledInput [TextField] Fix hiddenLabel type of FilledInput May 14, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels May 14, 2021
@oliviertassinari
Copy link
Member

I have used this as an opportunity to have inline preview #22484.

Screenshot 2021-05-15 at 19 12 05

@siriwatknp
Copy link
Member Author

siriwatknp commented May 17, 2021 •
edited

@oliviertassinari the demo changed (label removed) cause the test to fail, how can I update the test?

Found a way to approve changes in argos, thanks.

@siriwatknp siriwatknp requested a review from mnajdova May 17, 2021 09:43
@siriwatknp siriwatknp merged commit 10d8ae1 into mui:next May 17, 2021
@siriwatknp siriwatknp deleted the filled-input-hidden-label branch May 17, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Typescript] no hiddenLabel on FilledInput
4 participants
@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova