[test] Move ClockPicker tests to ClockPicker.test #26407
Conversation
eps1lon
added
test
component: pickers
| expect(handleViewChange.callCount).to.equal(0); | ||
| }); | ||
|
|
||
| it('should not select second when hour is disabled', () => { |
There was a problem hiding this comment.
This was previously worded "should not select disabled second" which is inaccurate. The reason the change wasn't fired was that the hour is disabled. So I used a similar wording from a previous test ("should not select minute when hour is disabled").
Now that I think about it: This wording make it sound like each time part is viewed differently i.e. we're validating each part individually. But we actually check if the full time is within [minTime, maxTime] not just if the selected hour is in [getHour(minTime), getHour(maxTime)].
So
| it('should not select second when hour is disabled', () => { | |
| it('should not select second when time is disabled', () => { |
sounds less ambigious. At least I was confused about this originally thinking that selecting 30s wouldn't be allowed if we have [12:30:10, 15:45:20] since 30 is not within [10, 20]. But the seconds only matter if the current time was within [minTime, maxTime].
Noticed in #26400 that MobileTimePicker was mostly responsible for ClockPicker testing. So I moved the tests from MobileTimePicker to ClockPicker to make them easier discoverable.
Used the opportunity to rewrite the tests with a more focused-testing approach.