Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Correctly select items in deeply nested trees #26413

Merged
merged 1 commit into from May 22, 2021

Conversation

Dru89
Copy link
Contributor

@Dru89 Dru89 commented May 21, 2021

This should fix #26404 using the implementation I suggested in the issue.

@mui-pr-bot
Copy link

mui-pr-bot commented May 21, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 6bf227e

@Dru89
Copy link
Contributor Author

Dru89 commented May 21, 2021

Note that, at least locally, a different test seems to be failing:

<DesktopDateTimePicker />
       does not close on click inside:
       Expected test not to call console.error() but instead received 6 calls.

Looks like all of the warnings are:

When testing, code that causes React state updates should be wrapped into act(...):

act(() => {
  /* fire events that update state */
});
/* assert on the output */

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels May 21, 2021
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eps1lon eps1lon merged commit 5371b14 into mui:next May 22, 2021
@eps1lon
Copy link
Member

eps1lon commented May 22, 2021

@Dru89 It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@Dru89 Dru89 deleted the fix-deeply-nested-tree-item branch May 22, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeView with multiSelect fails across deeply nested children.
4 participants