Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix peer dependencies declaration with yarn v2 #26433

Merged
merged 3 commits into from May 23, 2021
Merged

[core] Fix peer dependencies declaration with yarn v2 #26433

merged 3 commits into from May 23, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 23, 2021 •
edited

This is a follow-up on the lead given in #20012 (comment). I have created a new project with yarn v2 and vite, using the date picker. It yields two resolution issues:

Screenshot 2021-05-23 at 16 03 23

I have pushed:

  • 5353bd6 to solve the first error. The system doesn't need react-dom, so it won't complain in the lab that depends on it.
  • 180ac23 to solve the second error. react-transition-group depends on react-dom, we need to declare it.
  • dc28ce4 bonus

@oliviertassinari oliviertassinari mentioned this pull request May 23, 2021
Closed
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label May 23, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 23, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against dc28ce4

@oliviertassinari oliviertassinari changed the title [core] Improve peer dependency [core] Fix peer dependencies declaration with yarn v2 May 23, 2021
@oliviertassinari oliviertassinari merged commit 6a58eed into mui:next May 23, 2021
@oliviertassinari oliviertassinari deleted the improve-peer-dependency branch May 23, 2021 21:19
@oliviertassinari oliviertassinari mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-pr-bot @eps1lon