Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0-alpha.35 #26499

Merged
merged 5 commits into from
May 31, 2021
Merged

v5.0.0-alpha.35 #26499

merged 5 commits into from
May 31, 2021

Conversation

oliviertassinari
Copy link
Member

No description provided.

@mui-pr-bot
Copy link

mui-pr-bot commented May 29, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 503d653

@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-material-ui",
"version": "5.0.0-alpha.33",
"version": "5.0.0-alpha.35",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be increment by 1 => 5.0.0-alpha.34?

I have no strong opinion here since it is still in alpha, but I lean toward whatever lerna version gave us. Last time that I did the release, I feel like there will be some error prone if we make the change manually.

If we want the version to be the same, then we should use independent: false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The above version was expected.

We have configured lerna version for the version to be independent because what "framer" needed was unclear. But the target is:

diff --git a/lerna.json b/lerna.json
index 06cff9cd69..8a385eae09 100644
--- a/lerna.json
+++ b/lerna.json
@@ -1,5 +1,5 @@
 {
   "npmClient": "yarn",
   "useWorkspaces": true,
-  "version": "independent"
+  "version": "5.0.0-alpha.35"
 }

I think that we should aim for the version to be as close as possible, at least, when in the same "realm". This makes it easier for the developers to manage versions. 1. At a glance at the package.json/yarn.lock you know if the versions are compatible. 2. Our approach to versioning in the documentation heavily depends on having a single version. 3. It's easier to communicate about the version of the product you are using (for us with announcements, between practitioners, etc.)

Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the explicit styleProps change land? If so, then we should document it as a breaking change.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@mnajdova
Copy link
Member

Did the explicit styleProps change land? If so, then we should document it as a breaking change.

Not yet, I think I was waiting for review and then forgot about that PR will merge it tomorrow morning. I am merging the PR for adding createStyled in system tough @oliviertassinari FYI

oliviertassinari and others added 3 commits May 31, 2021 22:00
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@oliviertassinari oliviertassinari dismissed eps1lon’s stale review May 31, 2021 20:08

styleProps is not yet merged: #26461

@oliviertassinari oliviertassinari merged commit 6c0afb6 into mui:next May 31, 2021
@oliviertassinari oliviertassinari deleted the v5.0.0-alpha.35 branch May 31, 2021 20:17
@zannager zannager added core Infrastructure work going on behind the scenes v5.x labels Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants