-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.0.0-alpha.35 #26499
v5.0.0-alpha.35 #26499
Conversation
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "eslint-plugin-material-ui", | |||
"version": "5.0.0-alpha.33", | |||
"version": "5.0.0-alpha.35", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be increment by 1 => 5.0.0-alpha.34
?
I have no strong opinion here since it is still in alpha, but I lean toward whatever lerna version
gave us. Last time that I did the release, I feel like there will be some error prone if we make the change manually.
If we want the version to be the same, then we should use independent: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above version was expected.
We have configured lerna version
for the version to be independent because what "framer" needed was unclear. But the target is:
diff --git a/lerna.json b/lerna.json
index 06cff9cd69..8a385eae09 100644
--- a/lerna.json
+++ b/lerna.json
@@ -1,5 +1,5 @@
{
"npmClient": "yarn",
"useWorkspaces": true,
- "version": "independent"
+ "version": "5.0.0-alpha.35"
}
I think that we should aim for the version to be as close as possible, at least, when in the same "realm". This makes it easier for the developers to manage versions. 1. At a glance at the package.json/yarn.lock you know if the versions are compatible. 2. Our approach to versioning in the documentation heavily depends on having a single version. 3. It's easier to communicate about the version of the product you are using (for us with announcements, between practitioners, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did the explicit styleProps
change land? If so, then we should document it as a breaking change.
Not yet, I think I was waiting for review and then forgot about that PR will merge it tomorrow morning. I am merging the PR for adding createStyled in system tough @oliviertassinari FYI |
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
79f5cf6
to
482c819
Compare
styleProps is not yet merged: #26461
No description provided.