Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix that value in onChange can be null in Rating Docs #26540

Closed
wants to merge 0 commits into from

Conversation

sakura90
Copy link
Contributor

@sakura90 sakura90 commented Jun 1, 2021

Converted the value type in onChange in Rating Docs for all languages from

value: number

to

value: number | null

Related #26497

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 1, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 215446c

@eps1lon
Copy link
Member

eps1lon commented Jun 1, 2021

Thanks for the work.

Did you see the directions I gave in #26497 (comment)? The files you changed are generate and shouldn't be edited manually.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Jun 1, 2021
@sakura90
Copy link
Contributor Author

sakura90 commented Jun 1, 2021

@eps1lon I read your comments. I don't completely understand the comments. Still working on the fix. Please hold on. Going to give an update again in 24 hours.

@sakura90
Copy link
Contributor Author

sakura90 commented Jun 1, 2021

The PR somehow got closed immediately after I reverted my previous change. Please look at this PR instead.

#26542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants