[Popover] Fix PaperProps.ref breaking positioning #26560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
eps1lon
reviewed
Jun 2, 2021
There was a problem hiding this comment.
Thanks for the work.
A couple of minor things:
- Did you run
yarn prettierand commit the changes? - If you're up to it, please write a separate test without
openPopover.
It was the right decision to reach for existing tools but this particular test is pre-dates our new testing approach. Your change hightlights this issue perfectly where a single added test now affects all existing test. Debugging existing tests became harder and tests should usually not change over time unless breaking changes are introduced.
eps1lon
added
bug 🐛
|
Yeah thanks for pointing out, I forgot to run For (2) - I will try to separate out the test. |
oliviertassinari
changed the title
oliviertassinari
approved these changes
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26538
Fixed by making use of
useForkRefutility as described in the issue comments.