Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Fix custom font size centering arrow #26570

Merged
merged 2 commits into from Jun 3, 2021
Merged

Conversation

sarahannnicholson
Copy link
Contributor

@sarahannnicholson sarahannnicholson commented Jun 2, 2021

Modifying the calc in order to center the select arrow vertically when the font size is changed [#26401}

Fixes #26401

Preview: https://deploy-preview-26570--material-ui.netlify.app/components/selects/

Modifying the calc in order to center the select arrow vertically when the font size is changed
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 2, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against b86f99b

@sarahannnicholson sarahannnicholson changed the title NativeSelectInput - Centering arrow [#29469] NativeSelectInput - Centering arrow [#26401] Jun 2, 2021
@oliviertassinari oliviertassinari changed the title NativeSelectInput - Centering arrow [#26401] [Select] Fix native select centering arrow Jun 2, 2021
@oliviertassinari oliviertassinari changed the title [Select] Fix native select centering arrow [Select] Fix select centering arrow Jun 2, 2021
@oliviertassinari oliviertassinari changed the title [Select] Fix select centering arrow [Select] Fix custom font size centering arrow Jun 2, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! labels Jun 2, 2021
Updating the comment to be more clear

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 👍

@eps1lon eps1lon merged commit 1433919 into mui:next Jun 3, 2021
@eps1lon
Copy link
Member

eps1lon commented Jun 3, 2021

@sarahannnicholson It's a great first pull request on Material-UI. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] Arrow / caret doesn't scale with theme typography changes
5 participants