Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Bundling fixtures should not override source build with published build #26657

Merged
merged 1 commit into from
Jun 8, 2021
Merged

[test] Bundling fixtures should not override source build with published build #26657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
35 changes: 21 additions & 14 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,11 +422,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture node-esm
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: |
Expand All @@ -449,11 +450,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture next-webpack4
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: yarn start
Expand All @@ -472,11 +474,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture next-webpack5
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: yarn start
Expand All @@ -495,11 +498,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture create-react-app
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: yarn start
Expand All @@ -518,11 +522,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture snowpack
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: yarn start
Expand All @@ -541,11 +546,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture vite
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: yarn start
Expand All @@ -564,11 +570,12 @@ jobs:
- run:
name: Prepare fixture
command: |
node ../../scripts/useBuildFromSource.js .
node ../../scripts/createFixture esbuild
- run:
name: Install dependencies
command: yarn
command: |
yarn
node ../../scripts/useBuildFromSource.js .
- run:
name: Test fixture
command: |
Expand Down
17 changes: 9 additions & 8 deletions test/bundling/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,16 @@ The created file might need some manual adjustment since not every edge case is
1. Use the node version you want to use (e.g. `nvm use 14.0.0`)
1. Prepare the package.json
- to test a Pull Request
- checkout branch
- `yarn`
- `yarn lerna run build --scope "@material-ui/*"`
- `cd` to fixture
- `node ../../scripts/useBuildFromSource.js .`
1. checkout branch
1. `yarn`
1. `yarn lerna run build --scope "@material-ui/*"`
1. `cd` to fixture
1. `yarn install`
1. `node ../../scripts/useBuildFromSource.js .`
- to test a published npm dist tag (e.g. `latest` or `next`) on npm
- adjust the dependencies in the package.json accordingly
1. `cd` to fixture
1. `yarn install`
1. `cd` to fixture
1. adjust the dependencies in the package.json accordingly
1. `yarn install`
1. `yarn start` should exit with 0

### In CI
Expand Down