Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Type BackdropProps according to styled version #26836

Merged
merged 3 commits into from Jun 24, 2021
Merged

[Modal] Type BackdropProps according to styled version #26836

merged 3 commits into from Jun 24, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 19, 2021

Previously ModalProps pointed to the unstyled modal props. So e.g. let backdropProps: ModalProps['BackdropProps'] = { onEntered: () ==> console.log('entered') } failed type checking even though it was valid when directly passed to <Modal />.

@eps1lon eps1lon added bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module! labels Jun 19, 2021
@eps1lon eps1lon requested a review from mnajdova June 19, 2021 07:57
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 19, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against aa62c9e

@eps1lon eps1lon marked this pull request as ready for review June 19, 2021 09:13
mnajdova
mnajdova approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks correct, we’ll need to re-checked the other components that use unstyled component underneath

@oliviertassinari oliviertassinari deleted the branch mui:next June 22, 2021 00:28
@oliviertassinari oliviertassinari changed the base branch from foo to next June 22, 2021 00:45
@eps1lon eps1lon merged commit 8624850 into mui:next Jun 24, 2021
@eps1lon eps1lon deleted the fix/Modal/BackdropProps branch June 24, 2021 08:35
@eps1lon eps1lon mentioned this pull request Jun 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eps1lon @mui-pr-bot @mnajdova @oliviertassinari