[Box] Fix TypeScript error on maxWidth prop #26859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case? |
oliviertassinari
changed the title
oliviertassinari
added
component: Box
|
@oliviertassinari This is my first time contributing to material-ui. Are there any resources or existing test cases (which test TypeScript functionality) that I can refer to write a test case for this bug? Should I write a test and just render the box component as done in #25771? |
oliviertassinari
approved these changes
Jun 22, 2021
|
@ansh-saini It's a great first pull request on Material-UI. Thank you for working on it! |
|
Thank you so much. This is very exciting for me. I will try to contribute more as I start to understand the code-base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TypeScript issue spotted in #25771