Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5.0.0 alpha.38 #26906

Merged
merged 8 commits into from
Jun 24, 2021
Merged

v5.0.0 alpha.38 #26906

merged 8 commits into from
Jun 24, 2021

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 23, 2021 •
edited
Loading

@siriwatknp siriwatknp requested review from mnajdova, oliviertassinari, eps1lon and michaldudak and removed request for mnajdova June 23, 2021 09:07
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 23, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 4e39960

@github-actions github-actions bot mentioned this pull request Jun 23, 2021
Closed
oliviertassinari
oliviertassinari reviewed Jun 23, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@siriwatknp @oliviertassinari
Apply suggestions from code review
aad5b70 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@siriwatknp siriwatknp force-pushed the v5.0.0-alpha.38 branch 2 times, most recently from 97ec18f to cd447d9 Compare June 23, 2021 11:36
@eps1lon
Copy link
Member

eps1lon commented Jun 23, 2021

Please don't put the changelog in the PR description or else everybody gets a GitHub notification. Reviewers can view the rendered changelog with 2 clicks from the PR: https://github.com/siriwatknp/material-ui/blob/v5.0.0-alpha.38/CHANGELOG.md

eps1lon
eps1lon approved these changes Jun 23, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
oliviertassinari and others added 2 commits June 23, 2021 14:43
@oliviertassinari
add visual illustration
5c2cfaf
@siriwatknp @eps1lon
Update CHANGELOG.md
499089c 
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@WilliamKelley WilliamKelley mentioned this pull request Jun 23, 2021
Open
@siriwatknp siriwatknp merged commit f60126f into mui:next Jun 24, 2021
@siriwatknp siriwatknp deleted the v5.0.0-alpha.38 branch June 24, 2021 03:38
@zannager zannager added docs Improvements or additions to the documentation v5.x labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation v5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@siriwatknp @mui-pr-bot @eps1lon @oliviertassinari @zannager