Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Convert Modal tests to testing-library #26912

Merged
merged 2 commits into from Jun 24, 2021
Merged

[test] Convert Modal tests to testing-library #26912

merged 2 commits into from Jun 24, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 23, 2021

Part of #22911

@eps1lon eps1lon added the test label Jun 23, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 23, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against ca1b083

eps1lon
eps1lon commented Jun 23, 2021
View reviewed changes
packages/material-ui/src/Modal/Modal.test.js
const backdrop = wrapper.find(Backdrop);
expect(backdrop.exists()).to.equal(true);

const transition = backdrop.find(Fade);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already tested in Backdrop.test

@eps1lon eps1lon mentioned this pull request Jun 23, 2021
Closed
46 tasks
@eps1lon eps1lon marked this pull request as ready for review June 23, 2021 14:15
@github-actions github-actions bot mentioned this pull request Jun 23, 2021
Closed
@eps1lon eps1lon merged commit 0f3e741 into mui:next Jun 24, 2021
@eps1lon eps1lon deleted the test/Modal/testing-library branch June 24, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eps1lon @mui-pr-bot