Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Make remaining testing-library tests StrictMode compatible #26924

Merged
merged 3 commits into from Jun 24, 2021
Merged

[test] Make remaining testing-library tests StrictMode compatible #26924

merged 3 commits into from Jun 24, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 24, 2021

Part of #13394

@eps1lon eps1lon added the test label Jun 24, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jun 24, 2021 •
edited

No bundle size changes (experimental)

Generated by 🚫 dangerJS against e8558ec

@eps1lon eps1lon marked this pull request as ready for review June 24, 2021 08:31
eps1lon
eps1lon commented Jun 24, 2021
View reviewed changes
packages/material-ui/test/integration/Select.test.js
Comment on lines -133 to -134
// StrictModeViolation: Requires fake timers + act
{ strict: false },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have been fixed somewhere in between now and #21817

@github-actions github-actions bot mentioned this pull request Jun 24, 2021
Closed
@eps1lon eps1lon merged commit 27027bc into mui:next Jun 24, 2021
@eps1lon eps1lon deleted the test/StrictModeViolation branch June 24, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eps1lon @mui-pr-bot