[Docs] migrate select-field to the new standard #2694
Conversation
alitaheri
added
docs
alitaheri
force-pushed
the
docs-codgen-select-field
branch
from
12e27ec
to
6a7adf9
Compare
| import SelectField from 'material-ui/lib/SelectField'; | ||
| import MenuItem from 'material-ui/lib/menus/menu-item'; | ||
|
|
||
| export default class SelectFieldCustomLabelExample extends React.Component { |
There was a problem hiding this comment.
It should match the name of the file. I would put example before.
There was a problem hiding this comment.
Then it would be inconsistent with the requires.
There was a problem hiding this comment.
Then we should also invert the ordre in the import 😁.
I think that it's better to be more end more specific in the name.
There was a problem hiding this comment.
how about an exact match: ExampleCustomLabel and also in the Page component again, the exact name: ExampleCustomLabel?
There was a problem hiding this comment.
@oliviertassinari I think we should leave the discussion of this for when we want to move the docs to src.
There was a problem hiding this comment.
I don't get it.
I think that we should use SelectFieldExampleCustomLabel.
There was a problem hiding this comment.
I get what you mean. I'm only saying not all of the other pages follow what you say. We should change them all at once. I don't like to see some follow and some not. Besides it still wouldn't match the file name ExampleCustomLabel. I think we should have a discussion on this when we want to move these files to their corresponding component folder later on. we are still new to this way of organizing the docs.
There was a problem hiding this comment.
I don't like to see some follow and some not.
I agree. I think that the first component was right:
https://github.com/callemall/material-ui/blob/master/docs/src/app/components/pages/components/AppBar/ExampleIconMenu.jsx
|
@oliviertassinari Is this alright to merge? |
| /** | ||
| * The style object to use to override the `DropDownMenu`. | ||
| */ | ||
| selectFieldRoot: React.PropTypes.object, |
There was a problem hiding this comment.
We will have to do something about this property at some point. 😳
There was a problem hiding this comment.
definitely, I was like HOLY JESUS WHAT IS THIS!!!
we shouldn't introduce a lot of breaking changes. This has to wait a little longer -_-
|
@alitaheri I have tested it, great stuff 👍. |
alitaheri
force-pushed
the
docs-codgen-select-field
branch
from
8d33d7a
to
134ecd2
Compare
|
@oliviertassinari Thanks ^_^ I did as you asked. merge this if it's alright 😁 👍 👍 |
|
@alitaheri A litlle rebase and we can merge 👍 |
|
Yeah I forgot 😁 On it |
alitaheri
force-pushed
the
docs-codgen-select-field
branch
from
134ecd2
to
ecaef63
Compare
|
@oliviertassinari All done. merge if it's all good 😁 |
[Docs] migrate select-field to the new standard
|
@alitaheri Thanks! |
|
Thank you 🎉 🎈 🎉 |
Ok it's ready to review.
Closes #27, #2456, #2213
@oliviertassinari Take a look.