Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add a default mount implementation to conformance tests #26949

Merged
merged 3 commits into from Jun 28, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 25, 2021

Allows us to remove usage of enzyme in most tests i.e. we remove the choice between enzyme and testing-library from most tests.

The goal is to make it straight forward to grep whether a tests needs enzyme (just search for createMount. mount is a bit too generic. Removing it from most tests is just better overall since it's one less concept people are confronted when reading a test.

Follow-up:

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 25, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 0c252e1

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 25, 2021

It will also make it harder for contributors to write test cases with mount: true story https://github.com/mui-org/material-ui/pull/26791/files#r655786565 😁

@eps1lon
Copy link
Member Author

eps1lon commented Jun 25, 2021

It will also make it harder for contributors to write test cases with mount: true story #26791 (files)

That's the goal, yes. In the end there will be all but 2 non-legacy tests remaining that will use enzyme.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jun 26, 2021
@eps1lon eps1lon merged commit d594312 into mui:next Jun 28, 2021
@eps1lon eps1lon deleted the test/hide-enzyme branch June 28, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants