Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stepper] Add completed to global pseudo-classes #26953

Merged
merged 9 commits into from Jun 30, 2021

Conversation

michal-perlakowski
Copy link
Contributor

Fixes #26830.

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 25, 2021

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 3bfb274

},
},
);
reactApi.styles.globalClasses[key] = generateUtilityClass(generateMuiName(name), key);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we handle the docs in a different effort? It can be solved as a standalone issue. I also have a few doubt with how the name is used, there might be room for simplification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, don't hesitate to spin this off as a standalone PR. The solution is not obvious and fixing this will help. Otherwise, we can open a new issue for it once #26830 is closed.

@oliviertassinari

This comment has been minimized.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: stepper This is the name of the generic UI component, not the React module! labels Jun 26, 2021
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank a lot for fixing this @michal-perlakowski

@siriwatknp siriwatknp merged commit 9ef6f74 into mui:next Jun 30, 2021
@michal-perlakowski michal-perlakowski deleted the stepicon branch June 30, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: stepper This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stepper] Cannot customize StepIcon via rule name for style override
4 participants