[docs] Fix 404 links #26963
Merged
[docs] Fix 404 links #26963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
requested changes
Jun 26, 2021
docs/src/pages/guides/api/api.md
Outdated
| @@ -43,7 +43,7 @@ We avoid documenting native properties supported by the DOM like [`className`](/ | |||
|
|
|||
| ### CSS Classes | |||
|
|
|||
| All components accept a [`classes`](/customization/how-to-customize/#overriding-styles-with-classes) prop to customize the styles. | |||
| All components accept a `classes` prop to customize the styles. | |||
There was a problem hiding this comment.
I think we should rather evaluate what this section is for:
- do we still need it?
- where did the
overriding-styles-with-classessection go - why was the codeblock below removed
Again, please use accurate PR titles and description so that people can follow changes at a glance and not have to check each line changed to catch unrelated changes.
There was a problem hiding this comment.
These changes were meant to be straightforward cleanup for outdated content.
- I don't know
- We have removed it, we don't want developers to use this approach.
- It's about makeStyles, which is legacy.
There was a problem hiding this comment.
I have reverted, my intent was 404 fixex with no controversy on the changes. We can continue the discussion with @mnajdova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to have none, It's getting us closer to the target.